Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kdsingleapplication] new port #42647

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[kdsingleapplication] new port #42647

merged 1 commit into from
Dec 13, 2024
+79 −0

Conversation

drdanz
Copy link
Contributor

@drdanz drdanz commented Dec 11, 2024

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Dec 12, 2024
@drdanz drdanz force-pushed the kdsingleapplication branch from a0658aa to 3bbe2d9 Compare December 12, 2024 10:00
@drdanz drdanz force-pushed the kdsingleapplication branch from 3bbe2d9 to 3b195ea Compare December 12, 2024 10:38
@FrankXie05
Copy link
Contributor

The usage has been tested successfully locally on x64-windows.

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Dec 13, 2024
@JavierMatosD JavierMatosD merged commit 3b57fb2 into microsoft:master Dec 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankXie05 FrankXie05 FrankXie05 approved these changes

Assignees

@FrankXie05 FrankXie05

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drdanz @FrankXie05 @JavierMatosD